fix(Insight): improve URL encoding

LibreTexts · Dec 11, 2023 · f2124f9 · f2124f9
1 parent c7167c0
commit f2124f9
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/client/src/components/kb/KBPageEditMode.tsx b/client/src/components/kb/KBPageEditMode.tsx
@@ -96,7 +96,7 @@ const KBPageEditMode = ({
       if (!res.data.page || !res.data.page.slug) {
         throw new Error("Error creating page");
       }
-      window.location.assign(`/kb/${res.data.page.slug}`); // Redirect to new page
+      window.location.assign(`/insight/${res.data.page.slug}`); // Redirect to new page
     } catch (err) {
       handleGlobalError(err);
     } finally {

diff --git a/server/api/kb.ts b/server/api/kb.ts
@@ -642,12 +642,17 @@ function _sanitizeBodyContent(content: string) {
 }
 
 function _generatePageSlug(title: string, userInput?: string) {
-  if (userInput) {
-    const spacesReplaced = userInput.replace(/\s/g, "-");
-    return encodeURIComponent(spacesReplaced.toLowerCase());
+  let val = '';
+  if (userInput && userInput.length > 0) {
+    val = userInput;
+  } else {
+    val = title
   }
-  const spacesReplaced = title.replace(/\s/g, "-");
-  return encodeURIComponent(spacesReplaced.toLowerCase());
+  const trimmed = val.trim(); // remove leading and trailing whitespace
+  const noQuotations = trimmed.replace(/['"]+/g, ""); // remove quotations
+  const noSpecialChars = noQuotations.replace(/[!@#$%^&*]/g, ""); // remove special characters
+  const spacesReplaced = noSpecialChars.replace(/\s/g, "-"); // replace spaces with hyphens
+  return encodeURIComponent(spacesReplaced.toLowerCase()); // encode the slug
 }
 
 export default {