Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Insight): featured article padding #302

Merged
merged 2 commits into from
Jun 10, 2024
Merged

fix(Insight): featured article padding #302

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfda093
fix(Insight): featured article padding
hannahmcg Jun 10, 2024
10bc52a
change truncatestring to line-clamp
hannahmcg Jun 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions client/src/components/kb/FeaturedList/FeaturedList.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
.items-list {
display: grid;
grid-template-columns: repeat(auto-fill, 12rem);
justify-content: space-between;
grid-gap: 1rem;
display: flex;
flex-direction: row;
flex-wrap: wrap;
padding-top: 0.5rem;
}
.featured-article-card {
Expand All @@ -13,7 +12,7 @@
text-align: center;
width: 18rem;
height: 10rem;
padding: 0.5rem 0.3rem;
padding: 0.5rem 1rem;
margin-right: 1.5rem;
margin-bottom: 1.25rem;
cursor: pointer;
Expand All @@ -34,7 +33,8 @@
width: 20rem;
height: 18rem;
padding: 0.5rem;
margin-right: 1rem;
margin-right: 1.5rem;
margin-bottom: 1.25rem;
cursor: pointer;
border: 1px solid #e5e7eb;
border-radius: 8px;
Expand Down
4 changes: 2 additions & 2 deletions client/src/components/kb/FeaturedList/FeaturedPageCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,11 @@ const FeaturedPageCard = ({
<Icon name="trash" size="small" />
</div>
)}
<div className="flex flex-col">
<div className="flex flex-col px-4">
<p className="text-lg font-semibold flex-wrap">
{truncateString(page.page.title, 50)}
jakeaturner marked this conversation as resolved.
Show resolved Hide resolved
</p>
<p className="text-sm flex-wrap">{truncateString(page.page.description, 100)}</p>
jakeaturner marked this conversation as resolved.
Show resolved Hide resolved
<p className="text-sm flex-wrap my-1">{truncateString(page.page.description, 100)}</p>
</div>
<ConfirmDeleteFeaturedModal
open={showDeleteModal}
Expand Down
Loading