This repository was archived by the owner on Jan 13, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2
Add ProGuard to Maven build #5
Draft
TheDGOfficial
wants to merge
22
commits into
main
Choose a base branch
from
add-proguard-to-maven-build
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: Only for shrinking & optimizing. This also fixes the Maven Shade Plugin build warning. That warning was the actual reason we'll considering to switch ProGuard anyway. There is a PR fixes that but there have been 15 days and it has not yet been merged. Switching to Gradle is not a goal at this point, but maybe in future.
Note: This uses JCenter, we should switch to alternatives before release.
Will try proguard-gradle next
This should fix build
Apparently ProGuard 7.0.1 does not support Java 15 (it will be available on 7.1), but it is available on the master branch. Not sure what I can do there except waiting or downgrading to Java 14. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made in this Pull Request
Added ProGuard to Maven build.
Reason of the above changes are
Note: This only for shrinking & optimizing, NOT for obfuscating.
Other information about this Pull Request
This also fixes the Maven Shade Plugin build warning. That warning was the actual reason we'll considering to switch ProGuard anyway. There is a PR fixes that but there have been 15 days and it has not yet been merged. Switching to Gradle is not a goal at this point, but maybe in future.
Note: This uses JCenter. We will switch to another repository when it is available. See Guardsquare/proguard#54