Skip to content
This repository was archived by the owner on Jan 13, 2023. It is now read-only.

Add ProGuard to Maven build #5

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

TheDGOfficial
Copy link
Member

@TheDGOfficial TheDGOfficial commented Feb 15, 2021

Changes made in this Pull Request

Added ProGuard to Maven build.

Reason of the above changes are

Note: This only for shrinking & optimizing, NOT for obfuscating.

Other information about this Pull Request

This also fixes the Maven Shade Plugin build warning. That warning was the actual reason we'll considering to switch ProGuard anyway. There is a PR fixes that but there have been 15 days and it has not yet been merged. Switching to Gradle is not a goal at this point, but maybe in future.

Note: This uses JCenter. We will switch to another repository when it is available. See Guardsquare/proguard#54

Note: Only for shrinking & optimizing.

This also fixes the Maven Shade Plugin build warning. That warning was the actual reason we'll considering to switch ProGuard anyway. There is a PR fixes that but there have been 15 days and it has not yet been merged. Switching to Gradle is not a goal at this point, but maybe in future.
@TheDGOfficial TheDGOfficial added the enhancement New feature or request label Feb 15, 2021
@TheDGOfficial TheDGOfficial self-assigned this Feb 15, 2021
Mustafa ÖNCEL added 5 commits February 15, 2021 22:19
Note: This uses JCenter, we should switch to alternatives before release.
Will try proguard-gradle next
@TheDGOfficial
Copy link
Member Author

Apparently ProGuard 7.0.1 does not support Java 15 (it will be available on 7.1), but it is available on the master branch. Not sure what I can do there except waiting or downgrading to Java 14.

@TheDGOfficial TheDGOfficial added this to the v1.0 milestone Feb 17, 2021
@TheDGOfficial TheDGOfficial marked this pull request as draft February 17, 2021 16:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant