v0.1.2 #95
Merged
v0.1.2 #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for UUIDs in request payloads
This reverts commit b0ac959.
Unify parent accessor methods
Implement patient programs
Revamp test/publish actions
![code-review-doctor[bot]](https://avatars.githubusercontent.com/in/83430?s=60&v=4){kind=small}
welkin/models/assessment.py
Outdated
| def get(self, patient_id: str, encounter_id: str, *args, **kwargs): | ||
| return super().get( | ||
| f"{self._client.instance}/patients/{patient_id}/encounters/{encounter_id}/" | ||
| f"assessments", |
There was a problem hiding this comment.
Suggested change
| f"assessments", | |
| "assessments", |
f-string is unnecessary here. This can just be a string. More details.
test/test_base.py
Outdated
| assert args.varkw is not None, f"{v}.get must accept variable kwargs" | ||
| if cls in Patient.subresources: | ||
| try: | ||
| assert args.args.index("patient_id") == 1, f"patient_id must be first" |
There was a problem hiding this comment.
Suggested change
| assert args.args.index("patient_id") == 1, f"patient_id must be first" | |
| assert args.args.index("patient_id") == 1, "patient_id must be first" |
f-string is unnecessary here. This can just be a string. More info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.