Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for failing precision tests #251

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ankitgola005
Copy link
Contributor

@ankitgola005 ankitgola005 commented Oct 29, 2024

Fix for failing precision tests Fix precision tests.
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@ankitgola005 ankitgola005 changed the title Fix tests failing with Synapse 1.19.0 Fix for failing precision tests Oct 29, 2024
@ankitgola005
Copy link
Contributor Author

Manual test results

Category pytorch-lightning | pypi   pytorch-lightning | source   lightning | pypi   lightning | source  
  G1 G2 G1 G2 G1 G2 G1 G2
HPU General tests P P P P P P P P
HPU torch compile tests P P P P P P P P
HPU FSDP tests P P P P P P P P
HPU Deepspeed tests P P P P P P P P
HPU precision test P P P P P P P P
Standalone-only single card tests P P P P P P P P
Multi card(2) HPU test P P P P P P P P
FSDP PT Multi card(2) HPU test P P P P P P P P
FSDP Fabric Multi card(2) HPU test P P P P P P P P
Testing HPU examples P P P P P P P P

@jerome-habana jerome-habana marked this pull request as ready for review November 4, 2024 11:01
@ankitgola005 ankitgola005 mentioned this pull request Nov 4, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants