Skip to content

Commit

Permalink
Requires at least nvfuser 0.1.7.
Browse files Browse the repository at this point in the history
  • Loading branch information
wujingyue authored and Borda committed Mar 21, 2024
1 parent 7f7113f commit 1e8e7d2
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
2 changes: 1 addition & 1 deletion thunder/executors/nvfuserex_impl.py
Original file line number Diff line number Diff line change
Expand Up @@ -1091,7 +1091,7 @@ def broadcast_in_dim(


def _cat_check(tensors: list[TensorProxy], dim: int) -> bool:
if nv_version < LooseVersion("0.1.3"):
if nv_version < LooseVersion("0.1.7"):
return False

# Validates tensors and concatenated dimension lengths
Expand Down
5 changes: 1 addition & 4 deletions thunder/tests/opinfos.py
Original file line number Diff line number Diff line change
Expand Up @@ -2802,12 +2802,9 @@ def cat_wrapper(*args, dim):
active_if=(LooseVersion(torch.__version__) < "2.2.0"),
executors=("torchcompile",),
),
# cat op was introduced in nvFuser 0.0.5, but was disabled because of
# this failing test
# https://github.com/Lightning-AI/lightning-thunder/issues/1071
DecorateInfo(
pytest.mark.xfail(strict=True),
active_if=(nvfuser_version < "0.1.3"),
active_if=(nvfuser_version < "0.1.7"),
executors=("nvFuser",),
),
),
Expand Down

0 comments on commit 1e8e7d2

Please sign in to comment.