Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add thunderfx API #1535

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Add thunderfx API #1535

merged 3 commits into from
Dec 11, 2024

Conversation

kiya00
Copy link
Collaborator

@kiya00 kiya00 commented Dec 10, 2024

Before submitting
  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #1529.

@kiya00 kiya00 mentioned this pull request Dec 10, 2024
Closed
mruberry
mruberry reviewed Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff, @kiya00!

I wrote a question about how kwargs propagate to the two torch.compile instances

mruberry
mruberry approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! As a follow-up we should try to switch existing test cases that use the previous method of invoking thunderfx to this new one, too

@mruberry mruberry enabled auto-merge (squash) December 11, 2024 19:31
@mruberry mruberry merged commit 8e0faef into main Dec 11, 2024
41 checks passed
@mruberry mruberry deleted the fxapi branch December 11, 2024 19:31
@mruberry mruberry mentioned this pull request Dec 11, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mruberry mruberry mruberry approved these changes

@kshitij12345 kshitij12345 Awaiting requested review from kshitij12345

@IvanYashchuk IvanYashchuk Awaiting requested review from IvanYashchuk

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@t-vi t-vi Awaiting requested review from t-vi t-vi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ThunderFX: Interface UX
3 participants
@kiya00 @kshitij12345 @mruberry