Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused self_arg from thunder.dynamo.utils.is_node_supported_by_thunder #1546

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

crcrpar
Copy link
Collaborator

@crcrpar crcrpar commented Dec 12, 2024

What does this PR do?

As per title.

@mruberry
Copy link
Collaborator

The test failures appear to be unrelated:

Wrote XML report to coverage.xml
+ ./codecov --token=*** --commit=5efa041b7c2b6f256bf1571a043d58267faaf3e1 --flags=gpu,pytest,networks --name=GPU-coverage --env=linux,azure
/__w/_temp/b50911ff-a252-4a97-8003-3fbfbb5d1ac2.sh: line 14: ./codecov: No such file or directory

##[error]Bash exited with code '127'.

I filed #1547 for that issue

Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mruberry mruberry enabled auto-merge (squash) December 12, 2024 16:06
@mruberry
Copy link
Collaborator

fyi @t-vi this may require overriding the auto-merge

@mruberry mruberry merged commit d59f9ab into main Dec 13, 2024
41 checks passed
@mruberry mruberry deleted the crcrpar-patch-1 branch December 13, 2024 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants