Skip to content

Fix double iteration bug when resumed from a checkpoint. #20775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Fix double iteration bug when resumed from a checkpoint. #20775

wants to merge 7 commits into from
+90 −1

Conversation

sudiptob2
Copy link

@sudiptob2 sudiptob2 commented Apr 29, 2025 •
edited by github-actions bot
Loading

What does this PR do?

This PR fixes the double iter() bug discussed in #19427

Fixes #19427

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20775.org.readthedocs.build/en/20775/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Apr 29, 2025
@sudiptob2 sudiptob2 marked this pull request as ready for review April 29, 2025 18:56
Borda
Borda reviewed Apr 30, 2025
View reviewed changes
@sudiptob2 sudiptob2 mentioned this pull request May 2, 2025
Open
@nvski nvski mentioned this pull request May 3, 2025
Merged
@sudiptob2
Copy link
Author

@Borda Thanks for the review! Let me know if there's anything you'd like me to change. Otherwise, can we go ahead and merge this?

Borda
Borda reviewed May 12, 2025
View reviewed changes
Borda
Borda reviewed May 12, 2025
View reviewed changes
@sudiptob2 sudiptob2 force-pushed the fix/19427/double-iter branch 2 times, most recently from e451080 to 130102c Compare May 14, 2025 04:56
@sudiptob2
Copy link
Author

Hey, @Borda just wondering if anything is blocking this PR from merging?

Borda
Borda reviewed Jun 6, 2025
View reviewed changes
@sudiptob2 sudiptob2 force-pushed the fix/19427/double-iter branch 2 times, most recently from c03f7d0 to 9525a9a Compare June 27, 2025 06:25
@github-actions github-actions bot added docs Documentation related ci Continuous Integration fabric lightning.fabric.Fabric dependencies Pull requests that update a dependency file dockers package has conflicts labels Jun 27, 2025
@sudiptob2 sudiptob2 force-pushed the fix/19427/double-iter branch from 9525a9a to df95a0c Compare June 27, 2025 06:35
@sudiptob2
Copy link
Author

@Borda, I noticed a few mypy checks are failing, but they don't seem related to the changes in this PR. Should we ignore them for now? Let me know the next steps.

@sudiptob2 sudiptob2 force-pushed the fix/19427/double-iter branch 2 times, most recently from fcd9055 to a9d56fd Compare July 3, 2025 16:27
@sudiptob2 sudiptob2 force-pushed the fix/19427/double-iter branch from a9d56fd to 2f9cd44 Compare July 9, 2025 15:38
bhimrazy
bhimrazy reviewed Jul 19, 2025
View reviewed changes
src/lightning/pytorch/loops/loop.py
Comment on lines +42 to +46
@property
def is_resuming(self) -> bool:
"""Whether we're resuming training from a checkpoint."""
return self._resuming_from_checkpoint

Copy link
Collaborator

@bhimrazy bhimrazy Jul 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This variable _resuming_from_checkpoint seems a bit redundant. From the naming and context, it looks like _loaded_from_state_dict might already be serving a similar purpose. wdyt @sudiptob2 ?

cc: @Borda

@bhimrazy bhimrazy mentioned this pull request Jul 19, 2025
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@bhimrazy bhimrazy bhimrazy left review comments

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

Assignees
No one assigned
Labels
ci Continuous Integration dependencies Pull requests that update a dependency file dockers docs Documentation related fabric lightning.fabric.Fabric package pl Generic label for PyTorch Lightning package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

calling iter twice messes up dataloaders with queues
3 participants
@sudiptob2 @Borda @bhimrazy