-
Notifications
You must be signed in to change notification settings - Fork 3.6k
feat(fabric): introduce process-safe port management #21313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(fabric): introduce process-safe port management #21313
Conversation
219bc75 to
c48259e
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #21313 +/- ##
========================================
- Coverage 87% 87% -1%
========================================
Files 270 272 +2
Lines 23822 24150 +328
========================================
+ Hits 20795 20950 +155
- Misses 3027 3200 +173 |
1504dd1 to
252396e
Compare
|
@littlebullGit PR is looking good, can you please check the failing check and see if it just a random failure (it seemed to work before merging master) |
@SkafteNicki , the error seems not related. It failed to start a server within 20 sec. Maybe just try again. FAILED serve/test_servable_module_validator.py::test_servable_module_validator - Exception: The server didn't start within 20 seconds. |
cc125d4 to
3612cc4
Compare
What does this PR do?
Addresses comment: #21309 (comment)
Summary
📚 Documentation preview 📚: https://pytorch-lightning--21313.org.readthedocs.build/en/21313/