Skip to content

Conversation

@bhimrazy
Copy link
Collaborator

@bhimrazy bhimrazy commented Nov 3, 2025

What does this PR do?

Fixes #<issue_number>

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21328.org.readthedocs.build/en/21328/

This reverts commit 6a8d943.

Reason: The solution was thread-safe but not process-safe, which doesn't
solve the actual GPU CI issue where tests run in parallel processes.

The implementation added 1,208 lines of complex code that:
- Doesn't fix the root cause (process-level conflicts)
- Is over-engineered (12-24x more code than needed)
- Violates repository patterns

We'll implement a simpler, process-safe solution instead.
@bhimrazy bhimrazy self-assigned this Nov 3, 2025
@github-actions github-actions bot added fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package labels Nov 3, 2025
@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

❌ Patch coverage is 72.00000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 87%. Comparing base (739cf13) to head (88430d0).

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #21328     +/-   ##
=========================================
+ Coverage      80%      87%     +6%     
=========================================
  Files         270      270             
  Lines       23764    23692     -72     
=========================================
+ Hits        19040    20515   +1475     
+ Misses       4724     3177   -1547     

@bhimrazy
Copy link
Collaborator Author

bhimrazy commented Nov 3, 2025

Finally, it seems to have worked.

time reduction is mainly due to CUDA_LAUNCH_BLOCKING: "0" (ref: #21290)

image

Let's see if it works now for every run without needing a rerun.

@bhimrazy bhimrazy marked this pull request as draft November 4, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant