Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reverting optional task for v0.11 [wip] #1856

Closed
wants to merge 11 commits into from

Conversation

Borda
Copy link
Member

@Borda Borda commented Jun 23, 2023

What does this PR do?

Fixes #1670

Partial revert of #1252 for module-like metrics (not functional)
Facilitate/smooth compatibility before v1.0

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added help wanted Extra attention is needed Important milestonish refactoring refactoring and code health API / design labels Jun 23, 2023
@Borda Borda added this to the v0.11 milestone Jun 23, 2023
@Borda Borda changed the title reverting optional task for v0.11 reverting optional task for v0.11 [wip] Jul 3, 2023
@Borda Borda marked this pull request as ready for review July 3, 2023 11:51
@SkafteNicki
Copy link
Member

@Borda I would vote for us closing this PR and corresponding issue.
We have not had any user feedback that the task parameter is difficult to deal with, so I feels like unnecessary work keeping another version alive where it is not.

@Borda Borda closed this Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API / design help wanted Extra attention is needed Important milestonish refactoring refactoring and code health
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants