Mutual Information Score #2008
Merged
Mutual Information Score #2008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…san/metrics into 2003-mutual-info-score
for more information, see https://pre-commit.ci
SkafteNicki
reviewed
Aug 22, 2023
matsumotosan
commented
Aug 22, 2023
for more information, see https://pre-commit.ci
…san/metrics into 2003-mutual-info-score
SkafteNicki
reviewed
Aug 23, 2023
SkafteNicki
reviewed
Aug 23, 2023
Co-authored-by: Nicki Skafte Detlefsen <[email protected]>
Co-authored-by: Nicki Skafte Detlefsen <[email protected]>
…san/metrics into 2003-mutual-info-score
SkafteNicki
requested review from
lantiga,
Borda,
justusschock and
stancld
as code owners
SkafteNicki
approved these changes
Aug 25, 2023
There was a problem hiding this comment.
Good job @matsumotosan.
Just fixes two smaller issues, but PR LGTM :]
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2008 +/- ##
========================================
- Coverage 87% 35% -52%
========================================
Files 270 275 +5
Lines 15572 15649 +77
========================================
- Hits 13475 5469 -8006
- Misses 2097 10180 +8083 |
Borda
approved these changes
Aug 25, 2023
stancld
approved these changes
Aug 25, 2023
matsumotosan
added a commit
to matsumotosan/metrics
that referenced
this pull request
Sep 19, 2023
Co-authored-by: Nicki Skafte Detlefsen <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes part of #2003
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2008.org.readthedocs.build/en/2008/