Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New metric: Adjusted Rand Score #2032

Merged
merged 27 commits into from
Sep 7, 2023
Merged

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Aug 29, 2023

What does this PR do?

Fixes part of #2003

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2032.org.readthedocs.build/en/2032/

@SkafteNicki SkafteNicki mentioned this pull request Aug 29, 2023
13 tasks
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #2032 (0975c26) into master (163b0aa) will increase coverage by 0%.
The diff coverage is 95%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2032   +/-   ##
======================================
  Coverage      87%     87%           
======================================
  Files         283     285    +2     
  Lines       15934   15978   +44     
======================================
+ Hits        13832   13874   +42     
- Misses       2102    2104    +2     

@mergify mergify bot added the ready label Aug 29, 2023
@mergify mergify bot removed the has conflicts label Sep 1, 2023
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 1, 2023
@mergify mergify bot added the has conflicts label Sep 4, 2023
@mergify mergify bot added the ready label Sep 6, 2023
@SkafteNicki SkafteNicki enabled auto-merge (squash) September 6, 2023 10:01
src/torchmetrics/clustering/adjusted_rand_score.py Outdated Show resolved Hide resolved
src/torchmetrics/clustering/adjusted_rand_score.py Outdated Show resolved Hide resolved
@mergify mergify bot added the has conflicts label Sep 6, 2023
@mergify mergify bot removed the has conflicts label Sep 7, 2023
@SkafteNicki SkafteNicki merged commit 07a8aca into master Sep 7, 2023
66 checks passed
@SkafteNicki SkafteNicki deleted the newmetric/adjusted_rand_score branch September 7, 2023 07:41
matsumotosan pushed a commit to matsumotosan/metrics that referenced this pull request Sep 19, 2023
* initial implementation

* add init files

* add tests

* docs

* fix doc tests

* changelog

* fix

* change image

* fix

* use new inputs

* Update src/torchmetrics/clustering/adjusted_rand_score.py

---------

Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation New metric ready topic: Cluster
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants