Create inputs.py for clustering tests #2045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matsumotosan
requested review from
SkafteNicki,
Borda,
justusschock and
stancld
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2045 +/- ##
========================================
- Coverage 87% 36% -51%
========================================
Files 279 279
Lines 15828 15828
========================================
- Hits 13731 5632 -8099
- Misses 2097 10196 +8099 |
Borda
approved these changes
Sep 2, 2023
stancld
approved these changes
Sep 3, 2023
SkafteNicki
approved these changes
Sep 4, 2023
There was a problem hiding this comment.
@matsumotosan thanks for this PR.
I renamed the input a bit and added the type of inputs that is need for clustering metrics such as the one in this PR: #2036
matsumotosan
added a commit
to matsumotosan/metrics
that referenced
this pull request
Sep 4, 2023
Create inputs.py for clustering tests
matsumotosan
added a commit
to matsumotosan/metrics
that referenced
this pull request
Sep 19, 2023
Create inputs.py for clustering tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes part of #2003
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2045.org.readthedocs.build/en/2045/