Fix bootstrapping with few samples #2052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkafteNicki
requested review from
Borda,
justusschock and
stancld
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2052 +/- ##
========================================
- Coverage 87% 39% -48%
========================================
Files 281 281
Lines 15884 15886 +2
========================================
- Hits 13781 6191 -7590
- Misses 2103 9695 +7592 |
Borda
approved these changes
Sep 4, 2023
justusschock
approved these changes
Sep 6, 2023
Borda
pushed a commit
that referenced
this pull request
Sep 9, 2023
* fix * test * changelog (cherry picked from commit 8d82db0)
Borda
pushed a commit
that referenced
this pull request
Sep 11, 2023
* fix * test * changelog (cherry picked from commit 8d82db0)
matsumotosan
pushed a commit
to matsumotosan/metrics
that referenced
this pull request
Sep 19, 2023
* fix * test * changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2048
If bootstrapping is used with very little samples, there is a non-zero chance that non of them should be included in the bootstrap, which can lead to the underlying metric failing. Implements fix for this.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2052.org.readthedocs.build/en/2052/