Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New metric: Fowlkes-Mallows Index #2066

Merged
merged 7 commits into from
Sep 11, 2023

Conversation

matsumotosan
Copy link
Member

@matsumotosan matsumotosan commented Sep 9, 2023

What does this PR do?

Fixes part of #2003

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added documentation Improvements or additions to documentation topic: Cluster labels Sep 9, 2023
@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

Merging #2066 (493b434) into master (6960602) will decrease coverage by 51%.
The diff coverage is 94%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2066     +/-   ##
========================================
- Coverage      87%     36%    -51%     
========================================
  Files         285     287      +2     
  Lines       16021   16069     +48     
========================================
- Hits        13916    5821   -8095     
- Misses       2105   10248   +8143     

@mergify mergify bot added the ready label Sep 11, 2023
@SkafteNicki SkafteNicki mentioned this pull request Sep 11, 2023
13 tasks
@SkafteNicki SkafteNicki enabled auto-merge (squash) September 11, 2023 08:53
@SkafteNicki SkafteNicki merged commit 2dfe0a8 into Lightning-AI:master Sep 11, 2023
66 checks passed
matsumotosan added a commit to matsumotosan/metrics that referenced this pull request Sep 19, 2023
* initial commit

* Update pyproject.toml

* Update pyproject.toml again

* Update CHANGELOG.md

* fix import

* Update src/torchmetrics/functional/clustering/fowlkes_mallows_index.py

---------

Co-authored-by: Nicki Skafte Detlefsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ready topic: Cluster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants