Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: switch to new Lit template #2097

Merged
merged 6 commits into from
Sep 21, 2023
Merged

docs: switch to new Lit template #2097

merged 6 commits into from
Sep 21, 2023

Conversation

Borda
Copy link
Member

@Borda Borda commented Sep 21, 2023

What does this PR do?

apart from the new template is also:

  • stops publish docs on RTFD (only for PR will do it)
  • build artifact with fetches assets only for deployment not on PR
Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2097.org.readthedocs.build/en/2097/

@Borda Borda added the documentation Improvements or additions to documentation label Sep 21, 2023
@Borda Borda added this to the v1.2.0 milestone Sep 21, 2023
@Borda Borda changed the title switch to nex template docs: switch to new Lit template Sep 21, 2023
@Borda Borda enabled auto-merge (squash) September 21, 2023 14:51
@Borda
Copy link
Member Author

Borda commented Sep 21, 2023

hmm, the broken MD links seem to be unrelated... :/ #2098

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #2097 (dacfba0) into master (809bb5f) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2097   +/-   ##
======================================
  Coverage      87%     87%           
======================================
  Files         293     293           
  Lines       16299   16299           
======================================
  Hits        14177   14177           
  Misses       2122    2122           

@mergify mergify bot added the ready label Sep 21, 2023
@Borda Borda disabled auto-merge September 21, 2023 20:42
@Borda Borda merged commit e2150c5 into master Sep 21, 2023
57 of 62 checks passed
@Borda Borda deleted the docs/template branch September 21, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants