Resolve ANN102

[matsumotosan]

What does this PR do?

Resolve ANN102: missing-type-cls

Before submitting

• Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
• Did you read the contributor guideline, Pull Request section?
• Did you make sure to update the docs?
• Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

---

📚 Documentation preview 📚: https://torchmetrics--2149.org.readthedocs.build/en/2149/

[codecov]

Codecov Report

Merging #2149 (7fe7a18) into master (fdaab96) will increase coverage by 0%.
The diff coverage is 100%.

Additional details and impacted files

@@          Coverage Diff           @@
##           master   #2149   +/-   ##
======================================
  Coverage      87%     87%           
======================================
  Files         293     293           
  Lines       16410   16414    +4     
======================================
+ Hits        14266   14270    +4     
  Misses       2144    2144           

[stancld]

I'm not sure if we want to add type annotation for cls. Personally, I see this rule to be a bit abundant and annoying :D

[matsumotosan]

I think I accidentally fixed the wrong linter error. I can close this PR if this isn't a style we want to enforce.

[justusschock]

imo that would be fine but I think indexing the builtin type is not supported for every python version so we might want to consider something from the typing package instead

[stancld]

imo that would be fine but I think indexing the builtin type is not supported for every python version so we might want to consider something from the typing package instead

Yes, typing.Type should work here. type built-in for annotations was added in 3.9/3.10 I think

[matsumotosan]

Unit tests for old failed RuntimeError: CUDA error: no kernel image is available for execution on the...

[Borda]

Unit tests for old failed RuntimeError: CUDA error: no kernel image is available for execution on the...

seems we have some flakes in the system... :/

[Borda]

@stancld do you still have a request for changes? 🐰

resolved