replace setuptools' find_packages by find_namespace_packages
#2153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2153 +/- ##
======================================
Coverage 87% 87%
======================================
Files 293 293
Lines 16373 16373
======================================
Hits 14231 14231
Misses 2142 2142 |
stancld
approved these changes
Oct 8, 2023
matsumotosan
approved these changes
Oct 9, 2023
SkafteNicki
approved these changes
Oct 9, 2023
matsumotosan
pushed a commit
to matsumotosan/metrics
that referenced
this pull request
Oct 14, 2023
matsumotosan
pushed a commit
to matsumotosan/metrics
that referenced
this pull request
Oct 14, 2023
…es` (Lightning-AI#2153)" This reverts commit f3601e3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
following suggestion in Lightning-AI/pytorch-lightning#16756 (comment)
tested even with the legacy version
setuptools==41.0.0released in 2019Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2153.org.readthedocs.build/en/2153/