-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Newmetric: NRMSE #2442
base: master
Are you sure you want to change the base?
Newmetric: NRMSE #2442
Conversation
@SkafteNicki, what is missing here to make it land? 🐿️ |
@Borda should be ready now :] |
@SkafteNicki just a friendly ping :) seems almost done just revisit the examples... |
yes, just need the final tests to pass :] |
d0a5568
to
9fc79ae
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2442 +/- ##
========================================
- Coverage 69% 36% -33%
========================================
Files 334 322 -12
Lines 18153 18101 -52
========================================
- Hits 12570 6576 -5994
- Misses 5583 11525 +5942 |
…chmetrics into newmetric/nrmse
What does this PR do?
Fixes #2303
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2442.org.readthedocs.build/en/2442/