Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate num_outputs in R2 because it is no longer needed #2705

Merged
merged 7 commits into from
Sep 11, 2024

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Aug 29, 2024

What does this PR do?

Fixes #2703

Passes locally, but lets see if the full test suit passes

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2705.org.readthedocs.build/en/2705/

@SkafteNicki SkafteNicki added the enhancement New feature or request label Aug 29, 2024
@SkafteNicki SkafteNicki added this to the v1.5.0 milestone Aug 29, 2024
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69%. Comparing base (708f11d) to head (91722ed).
Report is 1 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2705   +/-   ##
======================================
  Coverage      69%     69%           
======================================
  Files         329     329           
  Lines       18070   18071    +1     
======================================
+ Hits        12496   12497    +1     
  Misses       5574    5574           

@mergify mergify bot added the ready label Sep 2, 2024
@Borda Borda enabled auto-merge (squash) September 6, 2024 09:29
@mergify mergify bot removed the ready label Sep 10, 2024
@Borda Borda merged commit 4ce2278 into master Sep 11, 2024
63 checks passed
@Borda Borda deleted the deprecate/num_outputs_r2 branch September 11, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please don't make us specify the number of outputs for R2Score
3 participants