Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: move reset seed to fixture [2/2] #2706

Merged
merged 13 commits into from
Aug 30, 2024
Merged

tests: move reset seed to fixture [2/2] #2706

merged 13 commits into from
Aug 30, 2024

Conversation

Borda
Copy link
Member

@Borda Borda commented Aug 29, 2024

What does this PR do?

Follow-up for #2702

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2706.org.readthedocs.build/en/2706/

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53%. Comparing base (c233f36) to head (f7ccd50).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2706     +/-   ##
========================================
- Coverage      69%     53%    -16%     
========================================
  Files         316     316             
  Lines       17900   17900             
========================================
- Hits        12327    9446   -2881     
- Misses       5573    8454   +2881     

@mergify mergify bot added the ready label Aug 30, 2024
@Borda Borda merged commit 7fc4177 into master Aug 30, 2024
61 checks passed
@Borda Borda deleted the doctests/seed branch August 30, 2024 11:52
Borda added a commit that referenced this pull request Sep 11, 2024
Borda added a commit that referenced this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants