-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect CLIP-IQA type hints #2952
Fix incorrect CLIP-IQA type hints #2952
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2952 +/- ##
========================================
- Coverage 70% 32% -38%
========================================
Files 346 332 -14
Lines 19172 19011 -161
========================================
- Hits 13428 6058 -7370
- Misses 5744 12953 +7209 |
for more information, see https://pre-commit.ci
@SkafteNicki Thanks! I really feel what you're worried about, and I am not very satisfied with this approach either. I have several rough ideas right now but none of them seems to be good enough. I'd like to work on this a little bit more. How or where do you think we should continue this discussion? |
What does this PR do?
Fixes #2951
Before submitting
autoclass
andautofunction
TYPE_CHECKING
would suffice, but that's not something I'm not willing to change.PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
frfr
📚 Documentation preview 📚: https://torchmetrics--2952.org.readthedocs.build/en/2952/