Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect CLIP-IQA type hints #2952

Merged
merged 10 commits into from
Feb 24, 2025

Conversation

wooseopkim
Copy link
Contributor

@wooseopkim wooseopkim commented Feb 12, 2025

What does this PR do?

Fixes #2951

Before submitting
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

frfr


📚 Documentation preview 📚: https://torchmetrics--2952.org.readthedocs.build/en/2952/

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 23.52941% with 13 lines in your changes missing coverage. Please review.

Project coverage is 32%. Comparing base (6ca9d13) to head (5d31fb7).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (6ca9d13) and HEAD (5d31fb7). Click for more details.

HEAD has 340 uploads less than BASE
Flag BASE (6ca9d13) HEAD (5d31fb7)
torch2.0.1+cpu 21 3
python3.10 63 9
Windows 14 2
cpu 98 14
torch2.6.0+cpu 7 1
python3.12 21 3
macOS 21 3
torch2.6.0 7 1
torch2.0.1 14 2
Linux 63 9
torch2.4.1+cpu 14 2
python3.11 7 1
torch2.1.2+cpu 7 1
torch2.2.2+cpu 7 1
torch2.5.0+cpu 14 2
torch2.3.1+cpu 7 1
python3.9 7 1
gpu 2 0
unittest 2 0
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2952     +/-   ##
========================================
- Coverage      70%     32%    -38%     
========================================
  Files         346     332     -14     
  Lines       19172   19011    -161     
========================================
- Hits        13428    6058   -7370     
- Misses       5744   12953   +7209     

@mergify mergify bot added the ready label Feb 14, 2025
@SkafteNicki SkafteNicki merged commit dec80a5 into Lightning-AI:master Feb 24, 2025
60 checks passed
@wooseopkim
Copy link
Contributor Author

@SkafteNicki Thanks! I really feel what you're worried about, and I am not very satisfied with this approach either. I have several rough ideas right now but none of them seems to be good enough. I'd like to work on this a little bit more. How or where do you think we should continue this discussion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLIP-IQA functions are incorrectly typed
3 participants