Skip to content

Conversation

VijayVignesh1
Copy link

@VijayVignesh1 VijayVignesh1 commented Sep 30, 2025

What does this PR do?

Fixes #3275

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review


Fixes UserWarning raised when using non-tuple sequence for multidimensional indexing.

Previously:

gathered_result[idx] = gathered_result[idx][slice_param]

Now:

gathered_result[idx] = gathered_result[idx][tuple(slice_param)]

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--3277.org.readthedocs.build/en/3277/

Copy link

codecov bot commented Sep 30, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 37%. Comparing base (122a852) to head (9d85be2).

❌ Your project check has failed because the head coverage (37%) is below the target coverage (95%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #3277    +/-   ##
=======================================
- Coverage      37%     37%    -1%     
=======================================
  Files         364     349    -15     
  Lines       20096   19901   -195     
=======================================
- Hits         7520    7326   -194     
+ Misses      12576   12575     -1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@rittik9 rittik9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot added the ready label Oct 4, 2025
@SkafteNicki SkafteNicki requested a review from lantiga as a code owner October 6, 2025 07:13
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation Warning in raised when calling gather_all_tensors
3 participants