Skip to content

Conversation

rittik9
Copy link
Collaborator

@rittik9 rittik9 commented Sep 30, 2025

What does this PR do?

Fixes #3258

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--3279.org.readthedocs.build/en/3279/

@rittik9 rittik9 marked this pull request as draft September 30, 2025 20:44
@rittik9 rittik9 marked this pull request as ready for review September 30, 2025 21:19
Copy link

codecov bot commented Sep 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 32%. Comparing base (122a852) to head (451bd60).

❗ There is a different number of reports uploaded between BASE (122a852) and HEAD (451bd60). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (122a852) HEAD (451bd60)
gpu 2 0
unittest 2 0
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #3279      +/-   ##
=========================================
- Coverage      99%     32%     -67%     
=========================================
  Files          15     349     +334     
  Lines         195   19901   +19706     
=========================================
+ Hits          194    6376    +6182     
- Misses          1   13525   +13524     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rittik9 rittik9 changed the title Add zero_division parameter to dice_score Fix: Remove undocumented zero_division reference from dice_score docstring. Oct 3, 2025
@Borda Borda changed the title Fix: Remove undocumented zero_division reference from dice_score docstring. Docs: Remove undocumented zero_division reference from dice_score docstring. Oct 4, 2025
@mergify mergify bot added the ready label Oct 4, 2025
@pre-commit-ci pre-commit-ci bot requested a review from lantiga as a code owner October 5, 2025 16:54
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zero_division defined in docstring but doesn't exist in segmentation.DiceScore
3 participants