Fix sigmoid overflow for large logits causing incorrect AUROC results #3283
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where
binary_auroc
and other classification metrics return incorrect results when logits are very large (>16.7 for float32, >36.7 for float64). The sigmoid function overflows to exactly 1.0 for all such values, losing the ranking information needed for AUROC calculation.Problem
When all logits are in a large range (e.g., 97-100), naive sigmoid application causes numerical overflow:
The issue occurs because
sigmoid(x)
forx > 16.7
evaluates to exactly1.0
in float32, making all predictions indistinguishable and destroying the ranking information that AUROC depends on.Solution
Modified
normalize_logits_if_needed
insrc/torchmetrics/utilities/compute.py
to apply numerically stable sigmoid when needed:min(logits) > 15
, indicating all values will overflowChanges
normalize_logits_if_needed()
to check both min and max values before stabilizationTesting
All existing tests pass:
Closes #XXXX
Original prompt
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.
📚 Documentation preview 📚: https://torchmetrics--3283.org.readthedocs.build/en/3283/