Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-adding WarpDrive example #350

Closed
wants to merge 2 commits into from
Closed

re-adding WarpDrive example #350

wants to merge 2 commits into from

Conversation

Borda
Copy link
Member

@Borda Borda commented Jul 26, 2024

This reverts commit 252a893.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #341

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda requested a review from ethanwharris as a code owner July 26, 2024 10:14
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70%. Comparing base (a01f01f) to head (78bba1a).

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #350   +/-   ##
===================================
  Coverage    70%    70%           
===================================
  Files         2      2           
  Lines       441    441           
===================================
  Hits        307    307           
  Misses      134    134           

@Borda
Copy link
Member Author

Borda commented Jul 26, 2024

seems some more fixes will be needed...

@Borda Borda closed this Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

withdrawing Reinforcement Learning With WarpDrive
1 participant