-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for CIFAR10 Dataset in the DCGAN Module #1046
base: master
Are you sure you want to change the base?
Conversation
[ | ||
transform_lib.Resize(script_args.image_size), | ||
transform_lib.ToTensor(), | ||
transform_lib.Normalize((0.5, 0.5, 0.5), (0.5, 0.5, 0.5)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this right with respect to the dataset color distribution?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the official PyTorch example seem to use the same normalization - https://pytorch.org/tutorials/beginner/blitz/cifar10_tutorial.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have a test for it?
@Borda @aniketmaurya I read more on it and calculated it as well, the values given in the pytorch docs are an approximation. The exact values are these: I will update the code accordingly with the exact values Reference - https://stackoverflow.com/questions/66678052/how-to-calculate-the-mean-and-the-std-of-cifar10-data |
for more information, see https://pre-commit.ci
What does this PR do?
This PR adds the CIFAR10 dataset as an option in the DCGAN module and updates the arguments accordingly.
Fixes # (issue)
#971
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://lightning-bolts--1046.org.readthedocs.build/en/1046/