Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: NanumSquare Neo 폰트 적용, 글로벌 스타일 수정 #1

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

ArpaAP
Copy link
Member

@ArpaAP ArpaAP commented Aug 27, 2024

구현한 기능

  • Global Style에 NanumSquare Neo 폰트 추가
  • font-weight 300(Light), 400(Regular), 700(Bold), 800(ExtraBold), 900(Heavy) 각각에 대해 폰트 파일 매핑
  • body 태그에 user agent stylesheet 에 의해 기본으로 들어가 있는 margin 제거

논의하고 싶은 내용

기타

  • Variable Font로 깔끔하게 적용하려고 했으나 왜인지 윈도우 환경에서 제대로 표시되지 않아서 그냥 기존 방식으로 적용했습니다.

@ArpaAP ArpaAP requested a review from toothlessdev August 27, 2024 17:53
Copy link
Member

@toothlessdev toothlessdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😊 e2e 샘플 테스트 파일은 삭제해두겠습니다

Comment on lines 5 to 17
padding: 0;
border: 0;

body {
margin: 0;
padding: 0;
border: 0;
font-family: "NanumSquareNeo", sans-serif;
}

box-sizing: border-box;

img {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이부분 제가 잘못 짰었네요..!

* {
    margin: 0;
    padding: 0;
    border: 0;
    box-sizing: border-box;
}

로 수정해두겠습니다!

@ArpaAP ArpaAP merged commit edbfe53 into develop Aug 28, 2024
2 checks passed
@ArpaAP ArpaAP deleted the feature/fonts branch August 28, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants