Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

결과보기 페이지 완성 및 기타 스타일 수정 #10

Merged
merged 5 commits into from
Aug 31, 2024

Conversation

ArpaAP
Copy link
Member

@ArpaAP ArpaAP commented Aug 31, 2024

구현한 기능

  • 결과보기 페이지 완성
  • RootLayout 컴포넌트 스타일에 height: 100vh 설정
  • Button 컴포넌트에 하드코딩된 컬러 속성을 var() 사용하여 동적으로 수정

논의하고 싶은 내용

기타

@ArpaAP ArpaAP requested a review from toothlessdev August 31, 2024 14:09
Copy link
Member

@toothlessdev toothlessdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~! LGTM 😊

Comment on lines +27 to +37
<Text size="s" color="gray">
OOO님의 동BTI는...
</Text>
<Text size="l" color="primary" weight="bold">
유니크한 체육을 즐기는 스포츠맨형
</Text>
</TitleContainer>
<Line />
<Text size="m" weight="bold">
OOO님을 위한 추천 동아리
</Text>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

시간나시면 useSearchParams 사용해서
/result?name=홍길동&type=AAA 이런식으로 받아서 결과를 표시할수 있도록 기능 구현해두면 좋을것 같아요~

@toothlessdev toothlessdev merged commit 938331c into develop Aug 31, 2024
2 checks passed
@toothlessdev toothlessdev deleted the feature/result-page branch August 31, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants