feat: select 페이지 생성 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toothlessdev
requested changes
Sep 4, 2024
|
구현하시느라 고생 많으셨습니다. 전체적으로 커밋들을 세분화하신 부분은 잘 진행하신 것 같습니다. 다만 코드들이 조금 정돈되면 좋겠다는 느낌을 많이 받은 것 같아요. 아무래도 일관성을 지킨 코드는 나중에 유지보수도 쉽고 협업하기에도 더 수월할 것이기 때문에 그 부분만 조금만 조심해서 코드 작성하면 좋을 것 같습니다! |
junyeokk
reviewed
Sep 5, 2024
junyeokk
reviewed
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구현한 기능
논의하고 싶은 내용
기타