Feature/result loading #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toothlessdev
requested changes
Aug 28, 2024
Comment on lines
9
to
15
| useEffect(() => { | ||
| const emojiInterval = setInterval(() => { | ||
| setCurrentEmojiIndex((prevIndex) => (prevIndex + 1) % emojis.length); | ||
| }, 1000); // 1초마다 이모지를 변경 | ||
|
|
||
| return () => clearInterval(emojiInterval); | ||
| }, []); |
There was a problem hiding this comment.
useEffect(function changeEmojiByInterval() {
const emojiInterval = setInterval(() => {
setCurrentEmojiIndex((prevIndex) => (prevIndex + 1) % emojis.length);
}, 1000);
return () => clearInterval(emojiInterval);
}, [])useEffect 사용시에 콜백함수에 익명함수가 아닌 특정 effect 를 실행한다는 것을 작명한 함수를 사용하면 코드가 더 깔끔할 것 같아요!
Comment on lines
24
to
26
| let index = 0; | ||
| let isDeleting = false; | ||
| let typeTimeout: NodeJS.Timeout; |
Comment on lines
18
to
20
| const [displayedText, setDisplayedText] = useState(""); | ||
| const [currentTextIndex, setCurrentTextIndex] = useState(0); | ||
| const [isCursorBlinking, setIsCursorBlinking] = useState(false); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구현한 기능
논의하고 싶은 내용
(서로 그 방법에 대한 논의가 필요할 것 같음)
기타