Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: CD를 위한 Github Action 워크플로우 작성 #22

Merged
merged 2 commits into from
Sep 7, 2024

Conversation

ArpaAP
Copy link
Member

@ArpaAP ArpaAP commented Sep 7, 2024

구현한 기능

  • 배포 자동화를 위해 Github Action 워크플로우 cd.yml 작성
    • ci.yml 워크플로우가 완료되면 이어서 cd.yml 수행되도록 설정
    • 소스 빌드 후 S3 업로드와 CloudFront Cache Invalidate 수행하도록 설정
    • AWS 계정 정보 등을 Repository Secrets에 secret variables 로 등록하여 cd.yml 에서 참조하도록 안전하게 구현

논의하고 싶은 내용

  • 지금 Route53 DNS 정보 확인해보니 서브도메인 www.dongbti.com만 CloudFront 배포에 연결되어 있는것 같은데, 루트 도메인(dongbti.com) 접속시 www.dongbti.com 로 redirect 하도록 하면 어떨까요?

기타

@toothlessdev
Copy link
Member

논의하고 싶은 내용

  • 지금 Route53 DNS 정보 확인해보니 서브도메인 www.dongbti.com만 CloudFront 배포에 연결되어 있는것 같은데, 루트 도메인(dongbti.com) 접속시 www.dongbti.com 로 redirect 하도록 하면 어떨까요?

좋은 생각인것 같습니다! CNAME 으로 등록해두겠습니다!

Copy link
Member

@toothlessdev toothlessdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@toothlessdev toothlessdev merged commit 2ea002e into develop Sep 7, 2024
1 check passed
@toothlessdev toothlessdev deleted the feature/cd branch September 7, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants