Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/main page 메인 페이지 퍼블리싱 #3

Merged
merged 25 commits into from
Aug 28, 2024

Conversation

2NNS-V
Copy link
Collaborator

@2NNS-V 2NNS-V commented Aug 28, 2024

구현한 기능

  • input 컴포넌트 추가
  • 메인 페이지 퍼블리싱
  • 사이드바 추가

논의하고 싶은 내용

  • 사이드바 메뉴 클릭 시 페이지 이동

기타

  • 수정사항
  • 사이드바 css 수정
  • Input 창 height 수정
  • 학과 input -> dropdown 으로 변경

@2NNS-V 2NNS-V added the enhancement New feature or request label Aug 28, 2024
@2NNS-V 2NNS-V requested a review from toothlessdev August 28, 2024 12:24
@2NNS-V 2NNS-V self-assigned this Aug 28, 2024
package.json Outdated Show resolved Hide resolved
src/components/navigation/SideBar.tsx Outdated Show resolved Hide resolved
src/components/typography/Text.tsx Outdated Show resolved Hide resolved
Copy link
Member

@toothlessdev toothlessdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<svg> 로 시작하는 부분을 복사해서 assets 디렉토리에 .svg 확장자로 파일을 만들어서 붙여놓고, 이미지 엘리먼트 처럼 사용하시면 돼요!

예)

<svg xmlns="http://www.w3.org/2000/svg" width="30" height="32" fill="none" onClick = {handleSideBar}>
            <g stroke="#37CDCD" stroke-linecap="round" stroke-linejoin="round" stroke-width="2" clip-path="url(#a)" filter="url(#b)">
                <path d="m22.5 7.5-15 15M7.5 7.5l15 15"/>
            </g>
            <defs>
                <clipPath id="a">
                    <path fill="#fff" d="M0 0h30v30H0z"/>
                </clipPath>
                <filter id="b" width="38" height="38" x="-4" y="0" color-interpolation-filters="sRGB" filterUnits="userSpaceOnUse">
                    <feFlood flood-opacity="0" result="BackgroundImageFix"/>
                    <feColorMatrix in="SourceAlpha" result="hardAlpha" values="0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 127 0"/>
                    <feOffset dy="4"/>
                    <feGaussianBlur stdDeviation="2"/>
                    <feComposite in2="hardAlpha" operator="out"/>
                    <feColorMatrix values="0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0.25 0"/>
                    <feBlend in2="BackgroundImageFix" result="effect1_dropShadow_82_77"/>
                    <feBlend in="SourceGraphic" in2="effect1_dropShadow_82_77" result="shape"/>
                </filter>
            </defs>
        </svg>
import icon from "@/assets/example.svg";
<img src={icon}/>

@2NNS-V
Copy link
Collaborator Author

2NNS-V commented Aug 28, 2024

Member

<svg> 로 시작하는 부분을 복사해서 assets 디렉토리에 .svg 확장자로 파일을 만들어서 붙여놓고, 이미지 엘리먼트 처럼 사용하시면 돼요!

예)

<svg xmlns="http://www.w3.org/2000/svg" width="30" height="32" fill="none" onClick = {handleSideBar}>
            <g stroke="#37CDCD" stroke-linecap="round" stroke-linejoin="round" stroke-width="2" clip-path="url(#a)" filter="url(#b)">
                <path d="m22.5 7.5-15 15M7.5 7.5l15 15"/>
            </g>
            <defs>
                <clipPath id="a">
                    <path fill="#fff" d="M0 0h30v30H0z"/>
                </clipPath>
                <filter id="b" width="38" height="38" x="-4" y="0" color-interpolation-filters="sRGB" filterUnits="userSpaceOnUse">
                    <feFlood flood-opacity="0" result="BackgroundImageFix"/>
                    <feColorMatrix in="SourceAlpha" result="hardAlpha" values="0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 127 0"/>
                    <feOffset dy="4"/>
                    <feGaussianBlur stdDeviation="2"/>
                    <feComposite in2="hardAlpha" operator="out"/>
                    <feColorMatrix values="0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0.25 0"/>
                    <feBlend in2="BackgroundImageFix" result="effect1_dropShadow_82_77"/>
                    <feBlend in="SourceGraphic" in2="effect1_dropShadow_82_77" result="shape"/>
                </filter>
            </defs>
        </svg>
import icon from "@/assets/example.svg";
<img src={icon}/>

merge 된거 오류 해결하고 svg 분리하였습니다

@2NNS-V 2NNS-V requested a review from toothlessdev August 28, 2024 15:12
Copy link
Member

@toothlessdev toothlessdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@toothlessdev toothlessdev merged commit 5ddfee5 into develop Aug 28, 2024
2 checks passed
@toothlessdev toothlessdev deleted the feature/main-page branch August 28, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants