Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

잡다한 것들 수정 #35

Merged
merged 4 commits into from
Sep 9, 2024
Merged

잡다한 것들 수정 #35

merged 4 commits into from
Sep 9, 2024

Conversation

ArpaAP
Copy link
Member

@ArpaAP ArpaAP commented Sep 9, 2024

구현한 기능

  • title 및 favicon 수정
  • DropDown 및 Input background-color 자연스럽게 수정
  • 상단 메뉴 스타일 수정

논의하고 싶은 내용

기타

Copy link
Member

@toothlessdev toothlessdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -14,7 +14,7 @@ export const SideBar = ({ isOpen, setIsOpen }: SideBarProps) => {
const outside = React.useRef<HTMLDivElement>(null);
const navigate = useNavigate();

React.useEffect(() => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@2NNS-V
React 를 import 해서 React.useEffect 와 같이 사용하면, useEffect 라는 함수를 React 전체에서 가져오게 됩니다
그렇기때문에 빌드시에 번들러가 트리쉐이킹을 진행하지 않게 됩니다

반면 import { useEffect } from "react" 와 같이 사용하면 useEffect 만 react 에서 가져오기 때문에 사용하지 않는 리액트의 내부 다른 부분은 번들에 포함되지 않게 됩니다!

그래서 아래의 방식으로 개별 import 하여 사용하는거 추천드립니다

트리쉐이킹과 번들러에 관련해서는

https://toothlessdev.gitbook.io/main/web-develop/javascript/javascript-bundler
제가 간단하게 정리한 내용인데 참고해보시면 좋을것 같습니다 !

@toothlessdev toothlessdev merged commit 706d8c1 into develop Sep 9, 2024
2 checks passed
@toothlessdev toothlessdev deleted the feature/miscellaneous branch September 9, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants