Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Select Page Mark1 #4

Closed
wants to merge 14 commits into from
Closed

feat: Select Page Mark1 #4

wants to merge 14 commits into from

Conversation

WithJo
Copy link
Collaborator

@WithJo WithJo commented Aug 28, 2024

구현한 기능

  • card

논의하고 싶은 내용

  • question 처리 방안

기타

@junyeokk
Copy link

junyeokk commented Aug 28, 2024

actions tab에 들어가서 build가 되지 않는 원인을 차근차근 읽어보고 고쳐보시는 것을 추천드립니다.

image

Copy link
Member

@toothlessdev toothlessdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment on lines +137 to +147
const Modal = ({ onClose }: { onClose: () => void }) => {
return (
<ModalOverlay onClick={onClose}>
<ModalContent>
<img src={swipe} alt="Swipe Icon" style={{ marginBottom: "20px" }} />
<Text size="m">좌우로 스와이프</Text>
<Text size="xs">또는 버튼으로 조작</Text>
</ModalContent>
</ModalOverlay>
);
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

얘도 다른 컴포넌트 파일로 분리하는게 좋아보입니다 src/components/feedback 에 넣으면 좋겠네요!

@WithJo WithJo closed this Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants