Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Text 굵기 선택 지원 + global.ts weight 추가 #5

Merged
merged 4 commits into from
Aug 29, 2024

Conversation

whitedev7773
Copy link
Collaborator

@whitedev7773 whitedev7773 commented Aug 28, 2024

구현한 기능

  • typograph/Text.tsx weight props 추가
  • weight | "l" | "r" | "b" | "eb" | "h", weight가 주어지지 않으면 기본값은 r로 설정
  • weight | "light" | "regular" | "bold" | "extrabold" | "heavy", weight가 주어지지 않으면 기본값은 regular로 설정

논의하고 싶은 내용

  • X

기타

  • light, regular, bold, extrabold, heavy

Copy link
Member

@toothlessdev toothlessdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@toothlessdev toothlessdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weight 프로퍼티를 좀 더 직관적으로 알 수 있게 바꾸면 좋을것 같습니다!

@junyeokk
Copy link

weight 프로퍼티를 좀 더 직관적으로 알 수 있게 바꾸면 좋을것 같습니다!

tailwind 참고해보는 것도 좋아요

https://tailwindcss.com/docs/font-weight

Copy link
Member

@toothlessdev toothlessdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@toothlessdev toothlessdev merged commit 84cfb6e into develop Aug 29, 2024
2 checks passed
@toothlessdev toothlessdev deleted the feature/font-weight branch August 29, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants