Feature/share 결과 공유 페이지 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toothlessdev
approved these changes
Aug 28, 2024
Comment on lines
+1
to
+15
| import { forwardRef } from "react"; | ||
|
|
||
| import { AppBarElement } from "./AppBar.style"; | ||
|
|
||
| export interface AppBarProps extends React.ComponentProps<"div"> { | ||
| children: React.ReactNode; | ||
| } | ||
|
|
||
| export const AppBar = forwardRef<HTMLDivElement, AppBarProps>(({ children, ...props }, ref) => { | ||
| return ( | ||
| <AppBarElement ref={ref} {...props}> | ||
| {children} | ||
| </AppBarElement> | ||
| ); | ||
| }); |
There was a problem hiding this comment.
forwardRef 는 리액트 노드의 ref 속성에 접근할때
예를들어 input, button 과 같은 경우에만 사용하면 될것 같습니다!
ref props 는 일반적인 props 와 다르게 React Fiber Node 에 저장되기 때문에 forwardRef 로 전달하는거에요!
그냥 styled component 를 사용하면 ref 도 자동으로 전달해주니 저런식으로 굳이 짤 필요는 없다고 생각됩니다!
There was a problem hiding this comment.
이해됐습니다! 다음 PR과 함께 수정하겠습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구현한 기능
논의하고 싶은 내용
기타