Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use project.layout.buildDirectory to replace deprecated project.buildDir api #157

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Use project.layout.buildDirectory to replace deprecated project.buildDir api #157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7662980
Convert Constants from class to object
5peak2me Jan 4, 2025
7421ef8
Use project.layout.buildDirectory to replace deprecated project.build…
5peak2me Jan 4, 2025
2d37887
Merge branch 'LikeTheSalad:main' into main
5peak2me Jan 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stem-plugin/src/main/java/com/likethesalad/stem/ResolvePlaceholdersPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ class ResolvePlaceholdersPlugin : BaseTemplatesProcessorPlugin(), AndroidExtensi
}

override fun getBuildDir(): File {
return project.buildDir
return project.layout.buildDirectory.get().asFile
}

@Suppress("UNCHECKED_CAST")
Expand Down
12 changes: 5 additions & 7 deletions stem-plugin/src/main/java/com/likethesalad/stem/modules/common/Constants.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
package com.likethesalad.stem.modules.common

class Constants {
companion object {
const val XML_STRING_TAG = "string"
const val XML_RESOURCES_TAG = "resources"
const val RESOLVED_FILE_NAME = "resolved.xml"
const val TEMPLATE_BASE_FILE_NAME = "templates"
}
object Constants {
const val XML_STRING_TAG = "string"
const val XML_RESOURCES_TAG = "resources"
const val RESOLVED_FILE_NAME = "resolved.xml"
const val TEMPLATE_BASE_FILE_NAME = "templates"
}
4 changes: 2 additions & 2 deletions ...src/main/java/com/likethesalad/stem/modules/common/helpers/files/AndroidXmlResDocument.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package com.likethesalad.stem.modules.common.helpers.files

import com.likethesalad.stem.modules.common.Constants.Companion.XML_RESOURCES_TAG
import com.likethesalad.stem.modules.common.Constants.Companion.XML_STRING_TAG
import com.likethesalad.stem.modules.common.Constants.XML_RESOURCES_TAG
import com.likethesalad.stem.modules.common.Constants.XML_STRING_TAG
import com.likethesalad.stem.modules.common.helpers.resources.utils.XmlUtils
import com.likethesalad.tools.resource.api.android.modules.string.StringAndroidResource
import org.w3c.dom.DOMException
Expand Down
4 changes: 2 additions & 2 deletions .../main/java/com/likethesalad/stem/modules/common/helpers/files/OutputStringFileResolver.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package com.likethesalad.stem.modules.common.helpers.files

import com.likethesalad.stem.modules.common.Constants.Companion.RESOLVED_FILE_NAME
import com.likethesalad.stem.modules.common.Constants.Companion.TEMPLATE_BASE_FILE_NAME
import com.likethesalad.stem.modules.common.Constants.RESOLVED_FILE_NAME
import com.likethesalad.stem.modules.common.Constants.TEMPLATE_BASE_FILE_NAME
import java.io.File

class OutputStringFileResolver {
Expand Down
Loading