change module version to v2 #132
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixing up a whole bunch of "/v2" needing added through the codebase |
AquiGorka
approved these changes
May 31, 2024
There was a problem hiding this comment.
@richardbremner approving to unblock, but I am not sure moving all the packages inside a v2 namespace is the best thing to do, does it bring any benefit that we could put in place without such a big move?
|
@richardbremner is this PR still relevant? |
|
@AquiGorka i think it's still relevant, because it fixes the go install, which is otherwise still broken |
|
If that's the case, then we should rebase, resolve the conflicts and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review Type Requested (choose one):
Summary
Upping the version to v2 and we'll use manual tagging to identify releases (for now)
Task/Issue reference
Closes: add_link_here
Details (optional)
We will leave the current circleci short sha tag versioning in place for now.
When we release we'll just create a tag with the next version number, ie.
git tag v2.0.x
git push origin v2.0.x
go install github.com/Lilypad-Tech/lilypad@latest will automatically pull down the highest semantic version