Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: go bindings #160

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Conversation

arsen3d
Copy link
Contributor

@arsen3d arsen3d commented Jun 13, 2024

Review Type Requested (choose one):

  • Logic - thorough check (from everybody doing review)

Summary

Calling ./stack go-bindings after compile

@@ -55,19 +55,23 @@ RUN echo "npx hardhat deploy --network devnet" >> run
RUN echo "npx hardhat run scripts/fund-services-ether.ts --network devnet" >> run
RUN echo "npx hardhat run scripts/fund-services-tokens.ts --network devnet " >> run
RUN echo "npx hardhat run scripts/print-l2-config.ts --network devnet" >> run
RUN echo "cd .." >> run
RUN echo "./stack go-bindings" >> run
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not run chain-boot directly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--network local_l2 vs --network devnet

docker/chain/Dockerfile Outdated Show resolved Hide resolved
docker/chain/Dockerfile Outdated Show resolved Hide resolved
@arsen3d arsen3d force-pushed the arsen/build-go-binding-on-compile branch from 814ef35 to 4d3aae1 Compare June 14, 2024 16:20
Copy link
Contributor

@AquiGorka AquiGorka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛓️ ⛓️ thanks @arsen3d !

@richardbremner richardbremner merged commit d79bdd4 into main Jul 4, 2024
@richardbremner richardbremner deleted the arsen/build-go-binding-on-compile branch July 4, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants