Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: blocked error channel #177

Merged
merged 1 commit into from
Jun 21, 2024
Merged

fix: blocked error channel #177

merged 1 commit into from
Jun 21, 2024

Conversation

hunjixin
Copy link
Contributor

@hunjixin hunjixin commented Jun 21, 2024

Review Type Requested (choose one):

  • Glance - superficial check (from domain experts)
  • Logic - thorough check (from everybody doing review)

error channel block when error occur, this make a black screen with nothing, add a 1 len buf for the channel

Summary

Provide a one line summary and link to any relevant references

Task/Issue reference

Closes: add_link_here

Details (optional)

Add any additional details that might help Code Reviewers digest this PR

How to test this code? (optional)

Anything else? (optional)

@hunjixin hunjixin self-assigned this Jun 21, 2024
@github-actions github-actions bot added the fix label Jun 21, 2024
@hunjixin hunjixin merged commit 34182bb into main Jun 21, 2024
3 checks passed
@hunjixin hunjixin deleted the fix/block_error_channel branch June 21, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants