Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exit early if the current version is not available #217

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

richardbremner
Copy link
Collaborator

Review Type Requested (choose one):

  • [ x ] Glance - superficial check (from domain experts)
  • Logic - thorough check (from everybody doing review)

Summary

I just added a check that the current version is available, because otherwise the script could do weird things

@richardbremner richardbremner requested a review from bgins July 1, 2024 06:30
@github-actions github-actions bot added the fix label Jul 1, 2024
Copy link
Collaborator

@bgins bgins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left a comment with a typo fix.


# Check if CURRENT_VERSION has a value
if [ -z "$CURRENT_VERSION" ]; then
echo "Error: Unable to determin CURRENT_VERSION."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
echo "Error: Unable to determin CURRENT_VERSION."
echo "Error: Unable to determine CURRENT_VERSION."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants