fix: websocket disconnect and goroutine leak #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hunjixin
force-pushed
the
fix/websocket_disconnect
branch
2 times, most recently
from
073e83f
to
fc76891
Compare
AquiGorka
approved these changes
Jul 12, 2024
hunjixin
force-pushed
the
fix/websocket_disconnect
branch
from
153e563
to
fc3d9c1
Compare
hunjixin
force-pushed
the
fix/websocket_disconnect
branch
from
fc3d9c1
to
79b7069
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review Type Requested (choose one):
Summary
Provide a one line summary and link to any relevant references
Task/Issue reference
Closes: add_link_here
Details (optional)
Add any additional details that might help Code Reviewers digest this PR
How to test this code? (optional)
Anything else? (optional)