build: devnet-contract-deploy #222
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgins
reviewed
Jul 2, 2024
bgins
reviewed
Jul 2, 2024
|
|
||
| - name: Commit and push | ||
| run: | | ||
| git add . |
There was a problem hiding this comment.
Optional, but might be good to target the directory where we expect changes. Helps to document it a bit better.
There was a problem hiding this comment.
We may need to generate binding, which is not in hardhat directory
There was a problem hiding this comment.
I think @bgins means: git add pkg/web3/bindings
There was a problem hiding this comment.
Have you identified which files are going to be added here?
Can you list them?
There was a problem hiding this comment.
Folders:
* pkg/web3/bindings
* hardhat/deployments
* hardhat/.openzeppelin
There was a problem hiding this comment.
The you have your list for git add
Co-authored-by: Brian Ginsburg <[email protected]>
Co-authored-by: Brian Ginsburg <[email protected]>
arsen3d
force-pushed
the
arsen/build-devnet-contract-deploy
branch
4 times, most recently
from
bbde6da
to
03d98a7
Compare
AquiGorka
reviewed
Jul 2, 2024
AquiGorka
reviewed
Jul 2, 2024
Co-authored-by: Brian Ginsburg <[email protected]>
arsen3d
force-pushed
the
arsen/build-devnet-contract-deploy
branch
from
03d98a7
to
ee2521e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review Type Requested (choose one):
Summary
Provides a way to migrate contracts on devnet.