Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove ntfs zone files #286

Merged
merged 1 commit into from
Aug 16, 2024
Merged

fix: remove ntfs zone files #286

merged 1 commit into from
Aug 16, 2024

Conversation

hunjixin
Copy link
Contributor

@hunjixin hunjixin commented Aug 9, 2024

Review Type Requested (choose one):

  • Glance - superficial check (from domain experts)
  • Logic - thorough check (from everybody doing review)

Summary

Provide a one line summary and link to any relevant references

Task/Issue reference

Closes: add_link_here

close #238

Details (optional)

Add any additional details that might help Code Reviewers digest this PR

How to test this code? (optional)

Anything else? (optional)

@github-actions github-actions bot added the fix label Aug 9, 2024
@walkah walkah self-requested a review August 15, 2024 17:01
Copy link
Collaborator

@walkah walkah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - good cleanup!

@walkah
Copy link
Collaborator

walkah commented Aug 15, 2024

Ah, @hunjixin can you re-push with signed commits? Thanks! 🙏

@hunjixin hunjixin merged commit 6b7b2dc into main Aug 16, 2024
2 checks passed
@hunjixin hunjixin deleted the fix/remove_ntfs_zone_files branch August 16, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove *.json:Zone.Identifier files in hardhat
2 participants