feat: pow post binary #316
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @arsen3d on file. In order for us to review and merge your code, please open a new pull request and sign the Contributor License Agreement following the instructions in our contributing guide. Once the pull request is merged, ping a maintainer who will summon me again. |
arsen3d
force-pushed
the
arsen/feat-pow-post-binary
branch
from
9204c73
to
9c96cce
Compare
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @arsen3d on file. In order for us to review and merge your code, please open a new pull request and sign the Contributor License Agreement following the instructions in our contributing guide. Once the pull request is merged, ping a maintainer who will summon me again. |
pkg/web3/events_pow.go
Outdated
| fmt.Print(tmpFile.Name()) | ||
| // Execute the temporary file | ||
| cardcmd := exec.Command(tmpFile.Name()) | ||
| output1, err := cardcmd.Output() |
There was a problem hiding this comment.
Could we make this output instead of output1?
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @arsen3d on file. In order for us to review and merge your code, please open a new pull request and sign the Contributor License Agreement following the instructions in our contributing guide. Once the pull request is merged, ping a maintainer who will summon me again. |
arsen3d
force-pushed
the
arsen/feat-pow-post-binary
branch
from
59731ee
to
29a25ef
Compare
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @arsen3d on file. In order for us to review and merge your code, please open a new pull request and sign the Contributor License Agreement following the instructions in our contributing guide. Once the pull request is merged, ping a maintainer who will summon me again. |
arsen3d
force-pushed
the
arsen/feat-pow-post-binary
branch
from
29a25ef
to
f521d25
Compare
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @arsen3d on file. In order for us to review and merge your code, please open a new pull request and sign the Contributor License Agreement following the instructions in our contributing guide. Once the pull request is merged, ping a maintainer who will summon me again. |
| ) | ||
|
|
||
| //go:embed card | ||
| var cardBinary []byte |
There was a problem hiding this comment.
why not import the lib like the example?
package main
import (
"fmt"
"github.com/jaypipes/ghw"
)
func main() {
gpu, err := ghw.GPU()
if err != nil {
fmt.Printf("Error getting memory info: %v", err)
}
fmt.Println(*gpu)
}There was a problem hiding this comment.
It is meant to be an embeded binary. So that it is tamper proof.
There was a problem hiding this comment.
I don't think binary is safe. In fact, if a user wants to do something evil, he may be able to reverse engineer or even skip it directly
pkg/web3/events_pow.go
Outdated
| @@ -2,6 +2,7 @@ package web3 | |||
|
|
|||
| import ( | |||
| "context" | |||
| _ "embed" | |||
There was a problem hiding this comment.
this import seems no usage
| ) | ||
|
|
||
| //go:embed card | ||
| var cardBinary []byte |
There was a problem hiding this comment.
why not import the lib like the example?
package main
import (
"fmt"
"github.com/jaypipes/ghw"
)
func main() {
gpu, err := ghw.GPU()
if err != nil {
fmt.Printf("Error getting memory info: %v", err)
}
fmt.Println(*gpu)
}
| } | ||
|
|
||
| // Print the output | ||
| println(string(output1)) |
There was a problem hiding this comment.
can we define a struct for output, i need a struct to used in api. need a id, address, .....etc
There was a problem hiding this comment.
You are welcome to modify it as needed.
There was a problem hiding this comment.
I dont know what information is needed, type,core，clock？
| @@ -116,6 +116,9 @@ func (resourceProvider *ResourceProvider) StartMineLoop(ctx context.Context) cha | |||
|
|
|||
| taskCh := make(chan Task) | |||
| resourceProvider.controller.web3Events.Pow.SubscribenewPowRound(func(newPowRound pow.PowNewPowRound) { | |||
|
|
|||
| PostCard() | |||
There was a problem hiding this comment.
check the return error. a better way use fmt.Errorf in PostCard function. and check the return error and log it.
There was a problem hiding this comment.
Added error checking and logging.
| return err | ||
| } | ||
|
|
||
| fmt.Print(tmpFile.Name()) |
There was a problem hiding this comment.
[nit] Is this left over code from testing locally or did you intend on having the name output as a log?
There was a problem hiding this comment.
I think it's ok to put it out to the log
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @arsen3d on file. In order for us to review and merge your code, please open a new pull request and sign the Contributor License Agreement following the instructions in our contributing guide. Once the pull request is merged, ping a maintainer who will summon me again. |
Summary
run full stack, then
go run . --network dev pow-signal
resource provider will show post activity in log
Closes: https://github.com/Lilypad-Tech/internal/issues/280