Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add GitHub Action for CI Unit Tests #334

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

Rodebrechtd
Copy link
Collaborator

@Rodebrechtd Rodebrechtd commented Sep 5, 2024

Summary

This pull request makes the following changes:

  • Add GitHub Action for CI Unit Tests
  • Comment out failing Controller unit test; will address in a separate issue

Explain the motivation for making these changes. Does this pull request implement a feature or fix a bug? Is it a docs change or a typo fix?

Improve CI process by adding unit tests at main pull request

Task/Issue reference

Closes: #279

@Rodebrechtd Rodebrechtd requested a review from a team as a code owner September 5, 2024 15:46
@cla-bot cla-bot bot added the cla-signed label Sep 5, 2024
@github-actions github-actions bot added the chore label Sep 5, 2024
Copy link
Contributor

@bgins bgins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we skip the controller tests instead of commenting them out? It's possible with chai to skip a describe test suite by adding a .skip. We could change

describe("Controller", () => {

to

describe.skip("Controller", () => { 

and the entire test suite will be skipped.

The benefit of skipping over commenting out is that skipped tests are still reported, which helps us to remember they are there.

Copy link
Contributor

@bgins bgins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for taking this one on. Much appreciated! 🙏

@bgins bgins merged commit 3700728 into Lilypad-Tech:main Sep 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add unit tests to CI
2 participants