feat: setup kademlia and warp sync #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zurcusa
approved these changes
Aug 28, 2024
src/main/java/com/limechain/polkaj/reader/ScaleCodecReader.java
Outdated
Show resolved
Hide resolved
georg-getz
reviewed
Aug 28, 2024
|
|
||
| // From Smoldot implementation: | ||
| // TODO: must check that votes_ancestries doesn't contain any unused entry | ||
| // TODO: there's also a "ghost" thing? |
There was a problem hiding this comment.
This comment is from the old Fruzhin. I just uncommented the class and added the verifyAsync method.
georg-getz
reviewed
Aug 28, 2024
georg-getz
reviewed
Aug 28, 2024
georg-getz
reviewed
Aug 28, 2024
src/main/java/com/limechain/sync/warpsync/action/RequestFragmentsAction.java
Outdated
Show resolved
Hide resolved
georg-getz
reviewed
Aug 28, 2024
Comment on lines
+62
to
+64
| // libp.addEventListener('peer:discovery', (evt) => console.log('Discovered:', evt.detail.id.toString())) | ||
| // libp.addEventListener('peer:connect', (evt) => console.log('Connected:', evt.detail.toString())) | ||
| // libp.addEventListener('peer:disconnect', (evt) => console.log('Disconnected:', evt.detail.toString())) |
There was a problem hiding this comment.
intentionally left commented out?
There was a problem hiding this comment.
Yes, the commented code in main.js is for testing purposes while developing the different protocols, and will be removed after all of them are done
georg-getz
reviewed
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes Fruzhin#495
Checklist: